This repository has been archived by the owner on Sep 26, 2018. It is now read-only.
Subscriber balance zero out when validity expire (Client dependent) #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkroo
reviewed
Jun 7, 2017
| credit_balance = crdt.PNCounter("default").serialize() | ||
| print "Validity expired for Susbcribers %s setting balance to 0" % ( | ||
| [subscriber.imsi for subscriber in subscribers],) | ||
| subscribers.update(crdt_balance=credit_balance) |
There was a problem hiding this comment.
just update the value to zero?
kkroo
suggested changes
Jun 8, 2017
| valid_through__lte=today) | ||
| if not subscribers: | ||
| return # Do nothing | ||
| credit_balance = crdt.PNCounter("default").serialize() |
There was a problem hiding this comment.
you don't need to deal with crdt's. You can use the getter/setter Subscriber property balance
shivkumarsah
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review subscriber balance zero out feature:
This PR is linked with #40